FIX: Force redis disconnect if lock acquisition takes too long #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were waiting to acquire the mutex for each connection before disconnecting it. This tries to ensure a clean disconnection, but has two issues: - It will block forever on long-running redis commands (e.g. Pub/Sub subscriptions) - When two clients trigger failover simultaneously, it can cause a deadlock where they each wait for the other's mutex This commit adds a 50ms timeout, after which the client is terminated forcefully. This may cause some form of Redis::BaseConnectionError, but we expect to see some errors like this during failover anyway, so consumers should be tolerant to it. This commit also fixes the disconnection for redis SubscribedClient instances, which were previously being skipped.
|
This still doesn't work... more refinement needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were waiting to acquire the mutex for each connection before disconnecting it. This tries to ensure a clean disconnection, but has two issues:
This commit adds a 50ms timeout, after which the client is terminated forcefully. This may cause some form of Redis::BaseConnectionError, but we expect to see some errors like this during failover anyway, so consumers should be tolerant to it.
This commit also fixes the disconnection for redis SubscribedClient instances, which were previously being skipped.