WIP: Move templates out of options

[scossar]

Based on this commit to the 10up fork of wp-discourse: https://github.com/10up/wp-discourse/commit/5c9d43c4333e136204d5a3b07192f4b368c3f518

This PR moves the html templates out of the plugin's options. If this is implemented, html templates will no longer be customizable through the options page. They can be customized through the theme using the filters that are applied to each function. A link to the documentation of how to do that is added to the settings page. Here is a tentative version: https://github.com/scossar/wp-discourse/wiki/Template-Customization

This PR also changes the plugin's text-domain from discourse to wp-discourse.

[mention-bot]

By analyzing the blame information on this pull request, we identified @retlehs, @iamntz and @santouras to be potential reviewers

[iamntz]

I'd say it's better to have ob_get_clean called outside the apply_filters (here and everywhere else).

My reasoning is this: if you want only to append some extra markup, you'll have to remember to clean the buffer on return. I think it's an unnecessary extra step...

[retlehs]

👍 instead of linking to the wiki on your fork, can you please go ahead and update the links to be based off this repo?

and since we require php 5.3, can you add a namespace to the top of that HTMLTemplates class?

[scossar]

Sure. Can I create the wiki on here?

[scossar]

I've added a namespace and rebased this with the current master branch. I still need to update the links. I can change the namespace if there's something you would rather use than WPDiscourse.

[retlehs]

namespace looks good, and yeah you can go ahead and add to the wiki on here

[retlehs]

tested this out and it looks good! thanks for doing this.

will merge once you've rebased and tag a new version soon

[retlehs]

still need the wiki URLs updated to this repo's 👀

mention me/reply once that's done and i'll merge

[erlend-sh]

I had a brief discussion about this with @scossar in a separate channel, so I'll repost here:

If it makes the plugin less error prone that'd be a big win, but at the same time losing the ability to easily style a theme using the HTML Template boxes would be a pretty great loss imo. In my side-project one of the volunteer devs used these templates to great effect. If he had to mess around with a functions.php file, I'm not so sure he would have bothered taking the time aside to style our comments.

What's your take on this @retlehs ? This does make theme tweaking more of a developer-y action.

[retlehs]

customizing HTML templates is developer-y to begin with, and having the markup editable in the admin is awkward. it also doesn't make sense for that HTML to be saved to the options table in the database.

[scossar]

@retlehs I've updated the URLs