Functionality for topic-map for wordpress #321
Conversation
|
I'm looking at this now. I'm unsure about how it works. I was expecting https://github.com/procourse/wpdc-embed-topic-map to be a WordPress plugin. How is that code meant to be used? |
|
That stuff is added to your theme. You've got to add the assets folder to the base of your theme, and then copy the contents of functions.php into your theme's functions.php file. If it could be made into a plugin, that would obviously be better for usability. |
|
If you can give me a couple of days to look at this, I'll have some ideas for you. I think it will be possible to do this with fewer changes to the WP Discourse plugin. |
|
@sudaraka94 I like this a lot! I think it would be a good idea to include the topic-map in the wp-discourse plugin. It would be enabled with an option so that sites that don't want it can disable it. I've tried adding the code from your theme to the plugin and it's working for me. Is it ok if I make a few changes to your PR? |
|
Hi @scossar, If this can be added to the plugin that would be really awesome. Please do make changes. :) By the way I really like how you keep the wp-discourse plugin. One of the most readable php code I have ever seen and It is a great inspiration for me. |
|
@sudaraka94 thanks! I've created a separate PR here: #324. It's built on top of your sudaraka94-master branch. Maybe we should do the work there and close this PR. Early next week I'll add some comments about what's going on in the PR. |
|
I will be closing the pr and moving to the new pr |
No description provided.