-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] topicStatus needs to be changed to topic-status #4
Comments
We update the plugin on a regular basis to account for new Discourse versions, but we only do that when the change is made in a numbered release. So this change will be made when 0.9.9.7 is released. |
Heya, is the bug fixed with that you actually have to retype in the adress else the ads wont show up. They only show up when someone navigates to a post directly now when switching in between posts. Please fix this! |
@discoursehosting I just tested you latest update, thanks! It fixes the topicStatus error but I think you missed a customHTML somewhere. I now see this:
|
This is a change that has been made AFTER v0.9.9.7 So instead of running against master, which changes 20 times per day, you should check out v0.9.9.7 by using |
Could you have a dev branch of the adsense plugin that is updated whenever and master remains true to the current discourse release? It is so simple to update a docker install now that it gets tempting to just try it out. |
We currently only update the plugin after a new numbered release, so that wouldn't be very useful. This time could be better spent in making Discourse being more forgiving to breaking changes that cause plugins to break so often. |
We bumped the Discourse version again today, since a security bug was fixed. |
Updated the plugin. Thanks for notifying @nlalonde ! |
It looks like there was a change recently in discourse that is not compatible with this plugin.
discourse/discourse@bb0cf87
As mentioned here.
I had a quick look and I guess that topic.js.handlebars needs to be updated. I don't know if you would want to somehow maintain backwards compatibility or I would have changed it myself.
The text was updated successfully, but these errors were encountered: