Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of maxStringLength and maxLinearStringLength for struct view #93

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

FeltBoots
Copy link

@FeltBoots FeltBoots commented Apr 1, 2022

What changed

  1. Move maxStringLength and maxLinearStringLength to config of struct view
  2. Simplify condition inside string length comparison to prevent misunderstanding of new properties

Motivation

I believe this feature might be useful for some projects. For example, it will be convenient for me. I run discovery inside browser devtools and want to tweak these params a little bit on window resize.

If you find my explanation not perfect in src/views/struct/struct.usage.js let me know I fix it.

@lahmatiy
Copy link
Member

lahmatiy commented Jul 6, 2022

@FeltBoots Thank you for the feature request and PR!
I thought about adding such options into struct's config. Looks like it's time to do it.

@lahmatiy lahmatiy merged commit 933c333 into discoveryjs:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants