Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to eslint 8 #550

Merged
merged 4 commits into from
May 1, 2023
Merged

Upgrade to eslint 8 #550

merged 4 commits into from
May 1, 2023

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented May 1, 2023

Upgrades eslint and eslint plugins.


@kulinda, do you know what the correct way to type this is? It does not accept @param {[key: string]: string[]} data.

/**
 * @param {object.<string, string[]>} data - dictionary of arrays of valid values for each key
 * @returns {object.<string, string>[]} - array of every possible dictionary where one value is chosen for each key
 */
  107:1  warning  Use object shorthand or index signatures instead of `Object`, e.g., `{[key: string]: string}`

edit: ignore this I am stupid

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 677e905
Status: ✅  Deploy successful!
Preview URL: https://c4e4a6b8.discretize-optimizer.pages.dev
Branch Preview URL: https://eslint-8.discretize-optimizer.pages.dev

View logs

@marcustyphoon marcustyphoon merged commit 7887325 into staging May 1, 2023
2 checks passed
@marcustyphoon marcustyphoon deleted the eslint-8 branch May 1, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant