Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update major dependencies: react 18; node 18; vite 4 #551

Merged
merged 7 commits into from
May 2, 2023

Conversation

marcustyphoon
Copy link
Collaborator

No description provided.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a870f5
Status: ✅  Deploy successful!
Preview URL: https://9c24370e.discretize-optimizer.pages.dev
Branch Preview URL: https://may-2-dependencies-2.discretize-optimizer.pages.dev

View logs

@marcustyphoon marcustyphoon changed the title Update misc dependencies Update major dependencies: react 18; node 18 May 2, 2023
@marcustyphoon marcustyphoon changed the title Update major dependencies: react 18; node 18 Update major dependencies: react 18; node 18; vite 4 May 2, 2023
@marcustyphoon marcustyphoon requested a review from hobinjk May 2, 2023 23:36
Copy link
Collaborator

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything worked locally after manually removing node_modules and reinstalling (it wouldn't be js development without some form of dependency tomfoolery)

"@babel/plugin-transform-modules-commonjs": "^7.17.9",
"@babel/plugin-transform-typescript": "^7.16.7",
"@babel/preset-react": "^7.16.7",
"@babel/preset-typescript": "^7.16.7",
"@babel/types": "^7.16.7",
"@cloudflare/workers-types": "^3.4.0",
"@cloudflare/workers-types": "^4.20230404.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a fascinating way to do a version number! nice stuff, cloudflare

@marcustyphoon
Copy link
Collaborator Author

after manually removing node_modules and reinstalling

Ah. Well. That's, you know, that's definitely how that's supposed to work :P

@marcustyphoon marcustyphoon merged commit 04be6f9 into staging May 2, 2023
2 checks passed
@marcustyphoon marcustyphoon deleted the may-2-dependencies-2 branch May 2, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants