Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all "sol.<blah>" from make_figs #46

Closed
jeffjennings opened this issue Feb 20, 2020 · 3 comments · Fixed by #55
Closed

remove all "sol.<blah>" from make_figs #46

jeffjennings opened this issue Feb 20, 2020 · 3 comments · Fixed by #55
Labels
enhancement New feature or request
Milestone

Comments

@jeffjennings
Copy link
Collaborator

Don't pass sol to make_figs, just pass the dict entries in sol that are needed to plot.

@jeffjennings jeffjennings changed the title remove all "sol." from make_figs remove all "sol.<blah>" from make_figs Feb 20, 2020
@mtazzari mtazzari added this to the Paper accepted & on arXiv milestone Feb 20, 2020
@mtazzari
Copy link
Collaborator

mtazzari commented Feb 20, 2020

The code works as it is right now, we can change the implementation later.

@rbooth200
Copy link
Collaborator

I'm not sure what the issue is here - it makes more sense to pass sol around here than split it up into its attributes

@jeffjennings
Copy link
Collaborator Author

I'm closing; just for reference, in make_figs.py,

  • make_full_fig and make_quick_fig take sol because they use multiple quantities and functions stored in sol

  • make_diag_fig doesn't take sol because it just needs sol.r and sol.q, so I pass those in directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants