Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add News api #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Rohitha-pudu
Copy link
Contributor

News Api #156

Closes #156

🗒️ Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have gone through rules of when PR will get merged.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have followed proper file structure.
  • I have gone through CONTRIBUTING GUIDELINES.md.

@dishamodi0910
Copy link
Owner

Hey @Rohitha-pudu, Thank you for creating PR! We will review it super soon. 😇❣️
As we continue to evolve and innovate, we encourage you to share your ideas, feedback, and code to help us push the boundaries of what's possible in the world of APIs🚀.
We hope you have followed CONTRIBUTING GUIDELINES.
Thank you for being an essential part of our community. Together, we'll keep building amazing things!
Don’t forget to ⭐ our repository!
Happy Coding!✨
Will See you soon❣️

@dishamodi0910
Copy link
Owner

@Rohitha-pudu I observed that your PR's are good to go but the commits of 2 separate API's are there in single PR. Would request you to create 2 separate PR's, each PR containing only single API.

@dishamodi0910 dishamodi0910 added under-review Review PR! CHANGES-REQUESTED Changes are needed. labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGES-REQUESTED Changes are needed. under-review Review PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Existing API Name] : News Api
2 participants