제안: DOMContentLoaded 이벤트 발생 시에 jews 파싱 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
후처리 코드를 where를 먼저 태우고 분기해야겠군여 |
|
아 이게 그렇게 하는 PR이구나 |
disjukr
added a commit
that referenced
this pull request
Nov 1, 2014
제안: DOMContentLoaded 이벤트 발생 시에 jews 파싱
|
반응속도도 훨씬 빨라진 것 같네요 굳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome 38(x64, Win 8.1)에서 AdBlock 미사용 시 세계일보 기사 페이지를 접속했을 때
document.readyState가interactive에서 머무는 문제가 발견되었습니다. 이에 대한 해결 방안으로DOMContentLoaded이벤트 발생 시 jews를 파싱하는 것을 제안합니다만, 이미load이벤트 기준으로 쓰인 코드들과 충돌이 예상되어 세계일보의 경우에만 따로DOMContentLoaded이벤트 시 발생하도록 처리해야 할까 싶습니다.