Feat: Add 2.10.0

[diavrank]

Changelog

[GeoffreyBooth]

The tests are failing for 2.10.0: https://github.com/disney/meteor-base/actions/runs/3954174678/jobs/6771345570

[diavrank]

mmm it's weird, it says: FAIL: (no message displayed)

Do you know how can I show the error detail?

[GeoffreyBooth]

You need to run the tests locally. Look inside test.sh to see what commands it runs and run them one-by-one on your local machine.

[diavrank]

It´s crashing something in test.js

I will be checking it out this weekend and I will let you know if I could fix it

[diavrank]

The problem is on line 9 of test.js, here:

await page.goto('http://localhost/');

I added a catch statement, and this is the error:

➜  meteor-base git:(add-2100) ✗ ./test.sh 2.10.0            
Testing Docker image geoffreybooth/meteor-base:2.10.0...
Creating test app...
Building test app Docker image...
Launching test app...
Running test...
Before node test.js
error:  Error: net::ERR_CONNECTION_REFUSED at http://localhost/
    at navigate (file:///Users/diavrank/Documents/meteor-base/test/node_modules/puppeteer-core/lib/esm/puppeteer/common/Frame.js:210:23)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Frame.goto (file:///Users/diavrank/Documents/meteor-base/test/node_modules/puppeteer-core/lib/esm/puppeteer/common/Frame.js:180:21)
    at async CDPPage.goto (file:///Users/diavrank/Documents/meteor-base/test/node_modules/puppeteer-core/lib/esm/puppeteer/common/Page.js:436:16)
    at async file:///Users/diavrank/Documents/meteor-base/test/test.js:9:3
FAIL: (no message displayed)

I already tried by updating puppeteer to the latest version but it didn't work. Also, I changed the port URL page to http://localhost:3000 but it didn't work either.

any suggestion @GeoffreyBooth ?

[GeoffreyBooth]

I already tried by updating puppeteer to the latest version but it didn’t work. Also, I changed the port URL page to http://localhost:3000 but it didn’t work either.

What this code is doing is launching the test app (like via the meteor command) and then running Puppeteer to connect to it and click some buttons and check for the expected HTML. Try running the app yourself locally via meteor; does it come up and you see the expected UI (something about “the button has been clicked X times” IIRC)? And then if you try to run it via the test Dockerfile, do you get the same? I think Puppeteer is connecting to port 80 because that’s what the Docker container’s port 3000 gets mapped to when it’s run.

Presumably the app isn’t launching correctly, so one or both of these direct ways of launching the test app should give you an error that you can investigate.

[diavrank]

@GeoffreyBooth I already found the cause, it was because we had a conditional with regex for 2.1* version, so, it was never entering to 2.10 conditional. To fix it, I had to change it to 2.1.* I guess I have to update the other one about 2.0*

however, as you can see, it's throwing another error. I guess is something related to a recent change you did in this part 9dc41e3

[diavrank]

Well, thinking twice, if 2.9.1 also had that error then I can guess that it's a normal behavior

➜  meteor-base git:(add-2100) ✗ ./test.sh 2.9.1 
Testing Docker image geoffreybooth/meteor-base:2.9.1...
Creating test app...
Building test app Docker image...
Launching test app...
Running test...
Before node test.js
Before elapsed variable
enter to else
PASS for geoffreybooth/meteor-base:2.9.1 with node:14.21.2-alpine after 5 min 14 sec
Error: No such image: example-app:latest

[diavrank]

There was another error in CI:

I will be updating the correct version names of 2.1 and 2.0

[diavrank]

mmm it seems 2.1.0 is not allowed:

➜  Documents meteor create myapp --release 2.1.0
Meteor 2.1.0: unknown release.

[diavrank]

@GeoffreyBooth Fixed :)

[GeoffreyBooth]

@GeoffreyBooth Fixed :)

Thank you for digging into this!