fix issue with openapi error response examples #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisjkl
commented
Mar 25, 2024
Comment on lines
+175
to
+191
| "404": { | ||
| "description": "NotFound404response", | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/NotFoundResponseContent" | ||
| }, | ||
| "examples": { | ||
| "TWO": { | ||
| "value": { | ||
| "message": "Notfoundmessage" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Here is an example of what wasn't happening prior, but is now.
dhpiggott
reviewed
Mar 26, 2024
dhpiggott
reviewed
Mar 26, 2024
...napi/src/software/amazon/smithy/openapi/fromsmithy/protocols/AlloyAbstractRestProtocol.scala
Outdated
Show resolved
Hide resolved
dhpiggott
approved these changes
Mar 26, 2024
Baccata
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where openapi conversion would put all examples (including error cases) on the
200response. This updates so that the error cases are instead grouped with the correct status codes.