Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how discriminated unions are translated #173

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Change how discriminated unions are translated #173

wants to merge 2 commits into from

Conversation

Baccata
Copy link
Contributor

@Baccata Baccata commented Jun 18, 2024

No description provided.

Baccata
Baccata commented Jun 18, 2024
View reviewed changes
modules/openapi/src/alloy/openapi/DiscriminatedUnion.scala Outdated
.build()
}.asJava

val alts = shape
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be inlined in the DiscriminatedUnionMemberComponents thing, it'd be cleaner.

@lewisjkl
Copy link
Contributor

Hmm the class that is triggering the mima warning should have probably been private to begin with. Should I ignore the warning or add the class back in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Baccata @lewisjkl