Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version on startup #42

Merged
merged 1 commit into from
May 12, 2023
Merged

Show version on startup #42

merged 1 commit into from
May 12, 2023

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented May 10, 2023

Description of changes:

Adds feature parity with the upstream by putting the server version into the version.properties resource in the Mill build. That way, it can be read at startup in the following part of the server init:

try {
props.load(SmithyLanguageServer.class.getClassLoader().getResourceAsStream("version.properties"));
message = "Hello from smithy-language-server " + props.getProperty("version") + "!";
} catch (Exception e) {
LspLog.println("Could not read Language Server version: " + e);

Demo:

Screen.Recording.2023-05-10.at.02.15.00.mov

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Baccata Baccata merged commit 0964bb7 into dss May 12, 2023
@Baccata Baccata deleted the show-version-startup branch May 12, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants