Fixes for stale, misattributed, and incorrect diagnostics #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
Nov 24, 2021
| @@ -187,33 +190,35 @@ public void didChange(DidChangeTextDocumentParams params) { | |||
| File tempFile = null; | |||
|
|
|||
| try { | |||
| tempFile = File.createTempFile("smithy", SmithyProject.SMITHY_EXTENSION); | |||
| if (params.getContentChanges().size() > 0) { | |||
There was a problem hiding this comment.
Without this, tempFile would be set before .get(0) blows up, and Option.ofNullable will not be reliable (it will have a filename, but the file will be empty)
keynmol
commented
Nov 24, 2021
| Either<Exception, SmithyProject> loadedModel = this.project.recompile(path); | ||
| String changedFileUri = original.map(File::getAbsolutePath).orElse(path.getAbsolutePath()); | ||
|
|
||
| public void report(Either<String, List<PublishDiagnosticsParams>> result) { |
There was a problem hiding this comment.
Reporting and recompilation are now separate, to aid with testing and general declutter.
Baccata
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
didChange. Instead:this.project) if we're not working with real files (as in the case ofdidOpenanddidSave). This prevents stale diagnostics from accumulating with every change until the user presses Save.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.