Scala cross compilation #218
Conversation
|
|
build.sc
Outdated
| extends JavaModuleTests | ||
| with ScalaVersionModule | ||
| with BaseMunitTests | ||
| } | ||
|
|
||
| object `readme-validator` extends BaseScalaNoPublishModule { | ||
| def moduleDeps = Seq(openapi, proto.core, `json-schema`) | ||
| object `readme-validator` |
There was a problem hiding this comment.
no need to cross-build this one, it's only used to validate the code that's in the readme.
build.sc
Outdated
| @@ -377,7 +394,9 @@ object proto extends Module { | |||
| } | |||
| } | |||
|
|
|||
| object examples extends BaseScalaModule with ScalaPBModule { | |||
| object examples extends Cross[ExamplesModule](scalaVersions) | |||
There was a problem hiding this comment.
probably no need to cross-build this one either.
| import software.amazon.smithy.model.traits._ | ||
| import software.amazon.smithy.model.traits.HttpTrait | ||
| import software.amazon.smithy.model.shapes._ | ||
| import software.amazon.smithy.model.shapes.{Shape => JShape} |
| .getOrElse(Set.empty) | ||
| .flatMap(_.keySet().asScala) | ||
| val auth = security.flatMap(securitySchemes.get).toVector | ||
| val authHint = if (auth.nonEmpty) List(Hint.Auth(auth)) else Nil | ||
| val schemes = securitySchemes.values.toVector | ||
| val securityHint = | ||
| if (schemes.nonEmpty) List(Hint.Security(schemes)) else Nil | ||
| val exts = GetExtensions.from(openApi) | ||
| val infoExts = GetExtensions.from(openApi.getInfo()) | ||
| val exts = GetExtensions.from(openApi.asInstanceOf[HasExtensions]) |
There was a problem hiding this comment.
I think we should be able to avoid the runtime cast by changing the signature of from to be more 2.12-friendly, but I may be mistaken
There was a problem hiding this comment.
EDIT : yeah okay, I had forgotten it was a reflective call that we need because the openapi library is horrendous.
I guess we could centralise the cast in a def unsafeFrom(a: Any)
| mutable.LinkedHashMap.from(all.map(a => a.id -> a)) | ||
| all | ||
| .map(a => a.id -> a) | ||
| .foldLeft(new mutable.LinkedHashMap[DefId, Definition]()) { |
There was a problem hiding this comment.
considering we're using a mutable structure, a good old foreach would have done : it's preferable to using a fold to mutate imho, as it's a better signal of mutability usage
There was a problem hiding this comment.
alternatively, use a ListMap I guess ? (hoping for it to be available in collections-compat)
| allShapes | ||
| .foldLeft(new mutable.LinkedHashMap[DefId, Definition]()) { | ||
| case (acc, (id, shp)) => | ||
| acc += (if (unused(id)) |
There was a problem hiding this comment.
ditto : if we'e gonna mutate, let's use a foreach
build.sc
Outdated
| ) | ||
| } | ||
| } | ||
|
|
||
| object cli extends BaseScalaModule with buildinfo.BuildInfo { | ||
| object cli extends Cross[CliModule](scalaVersions) |
There was a problem hiding this comment.
arguably, we don't really need to cross-build this one as CLI usage, as CLIs shouldn't be consumed as libraries.
There was a problem hiding this comment.
smithy-lang/smithy enters the room lol
There was a problem hiding this comment.
loll, sure but it's a self contained fat jar
so cross built or not it would not matter
but I was thinking they would have dropped it by now
| // ShapeBuilderOps[MemberShape.Builder, MemberShape](MemberShape | ||
| // .builder() | ||
| // .id(id.toSmithy) | ||
| // .target(tpe.toSmithy)).addHints(hints ++ jsonNameHint).build() |
semenodm
force-pushed
the
scala-cross-compilation
branch
from
c0e5a89
to
39dd9ca
Compare
Not all modules should be cross compiled
semenodm
force-pushed
the
scala-cross-compilation
branch
from
48a30fe
to
a7e3f9a
Compare
No description provided.