Rework proto translation #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured the creation of top level list/map wrapping messages under the right circumstance
Baccata
commented
Jan 31, 2024
| import software.amazon.smithy.model.Model | ||
| import software.amazon.smithy.model.validation.ValidatedResultException | ||
|
|
||
| class CompilerRendererSuite extends FunSuite { |
There was a problem hiding this comment.
this file probably presents the biggest changes : moved to another folder and a lot of tests were modified or added
Baccata
commented
Jan 31, 2024
| import scala.jdk.CollectionConverters._ | ||
| import scala.collection.compat._ | ||
|
|
||
| object ModelPreProcessor { |
There was a problem hiding this comment.
removed this as a lot of what it was doing is now un-necessary. The logic for guarding against conflicts in enum values moved to the Compiler
Baccata
commented
Jan 31, 2024
|
|
||
| import software.amazon.smithy.model.Model | ||
|
|
||
| object SmithyToProtoCompiler { |
There was a problem hiding this comment.
this is now the only exposed construct in the protobuf module
|
Deleting to recreate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on disneystreaming/alloy#131