timestamp format for proto #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisjkl
commented
Mar 13, 2024
buildSetup.sc
Outdated
| @@ -113,6 +115,14 @@ trait BaseScala213Module extends BaseScalaModule with ScalafmtModule { | |||
|
|
|||
| trait BaseScalaModule extends ScalaModule with BaseModule { | |||
|
|
|||
| override def repositoriesTask = T.task { | |||
There was a problem hiding this comment.
Need to remove this prior to merging
lewisjkl
commented
Mar 13, 2024
Comment on lines
106
to
108
| dependencies, | ||
| defaultScalaVersion = "2.13.10" | ||
| defaultScalaVersion = "2.13.12" | ||
| ) |
There was a problem hiding this comment.
Don't think this matters at all, but I guess might as well
lewisjkl
commented
Mar 13, 2024
| testFilteredErrors(debug = true, expectedCount = 5) | ||
| testFilteredErrors(debug = true, expectedCount = 4) |
There was a problem hiding this comment.
Assuming this is due to smithy model library being updated (transitively in alloy) to no longer output a debug event in some circumstance
Baccata
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for protoTimestampFormat trait. Depends on disneystreaming/alloy#149