UrlForm and AWS query support #1101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Obviously we don't want this to be the permanent solution but it at least confirms understanding of the problem. With this in place all the compliance tests except for the idempotency token case (which we're ignoring for now anyway) pass.
Credit to Oli.
kubukoz
reviewed
Jul 21, 2023
Comment on lines
+65
to
+66
| // TODO: Ensure minimal delay when these endpoints don't exist, e.g. | ||
| // when running locally. |
|
Closing this because it includes unfinished support for encoding and decoding - whereas the plan is to get encoding support good enough to merge and then follow up with decoding support. So I'll open a new PR for encoding support and then a follow up will add decoding support. |
|
Encoding support draft: #1112 |
|
Decoding support will be added back after that in #1113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.