Flatten AWS newtypes #1110
Merged
Flatten AWS newtypes #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS in their smithy specs have a tendency to create newtypes for the smithy standard shapes. As part of this change, introduce a projection transformer that will run as a preprocessor before code generation and will replace the newtypes (if they match some criteria) with references to the standard smithy shapes. For a newtype to be considered as being "replaceable" it has to match the following criteria: - doesn't have any traits (other than @default) - is a simple shape - the name matches the smithy shape (one exception is Date, as it will be replaced with Timestamp even though it doesn't actually match). - comes from an AWS namespace (i.e. starts with com.amazonaws)
|
|
|
|
Merged
denisrosca
commented
Jul 20, 2023
...les/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/src/main/scala/Main.scala
Show resolved
Hide resolved
kubukoz
reviewed
Jul 20, 2023
modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/build.sbt
Outdated
Show resolved
Hide resolved
...les/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/src/main/scala/Main.scala
Show resolved
Hide resolved
modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/test
Outdated
Show resolved
Hide resolved
...les/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/src/main/scala/Main.scala
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Jul 21, 2023
modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/test
Show resolved
Hide resolved
Baccata
reviewed
Jul 21, 2023
modules/codegen-plugin/src/sbt-test/codegen-plugin/aws-newtype-flatten/build.sbt
Outdated
Show resolved
Hide resolved
Baccata
reviewed
Jul 21, 2023
modules/codegen/src/smithy4s/codegen/transformers/AwsStandardTypesTransformer.scala
Outdated
Show resolved
Hide resolved
|
Pretty good work overall :) |
|
Need some help figuring out the reason for the build failure. Unfortunately, I can't see the error message 🤔 |
|
@denisrosca, just sync your branch with the latest |
kubukoz
approved these changes
Jul 21, 2023
|
@Baccata we cool here? |
Baccata
approved these changes
Jul 24, 2023
Baccata
merged commit f042dd4
into
disneystreaming:remove-reserved-types
13 checks passed
|
Thanks a lot for this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS in their smithy specs have a tendency to create newtypes for the smithy standard shapes. As part of this change, introduce a projection transformer that will run as a preprocessor before code generation and will replace the newtypes (if they match some criteria) with references to the standard smithy shapes.
For a newtype to be considered as being "replaceable" it has to match the following criteria: