Support range/length refinement providers for enums #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Oct 31, 2023
| @@ -82,6 +83,12 @@ object RefinementProvider { | |||
| implicit def mapLengthConstraint[K, V]: Simple[Length, Map[K, V]] = | |||
| new LengthConstraint[Map[K, V]](_.size) | |||
|
|
|||
| implicit def enumLengthConstraint[E <: Enumeration.Value]: Simple[Length, E] = | |||
There was a problem hiding this comment.
question: should we also have @pattern?
There was a problem hiding this comment.
@idRef would be nasty. If someone ever creates an enum that matches the ShapeId format, I'll personally go to their house and remove their github account.
There was a problem hiding this comment.
question: should we also have @pattern?
Is it allowed ? you mentioned range and length, but ...
kubukoz
approved these changes
Nov 2, 2023
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282
PR Checklist (not all items are relevant to all PRs)