Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RefinementProvider methods #1388

Conversation

msosnicki
Copy link
Contributor

@msosnicki msosnicki commented Feb 5, 2024

It is useful to have access to these methods sometimes in more dynamic context, when for example implicit def enumLengthConstraint[E <: Enumeration.Value] cannot be invoked, due to constraints, but it is very easy to provide a size.

EDIT: Weird, fails on [aws-sandbox] (aws-sandbox / Compile / compileIncremental) Compilation failed, it works locally, is it known to be flaky in CI for some reason?

@kubukoz
Copy link
Member

kubukoz commented Feb 5, 2024

I've seen similar flakiness in CI recently, looks like some nondeterminism in the compiler. Will retry

@kubukoz
Copy link
Member

kubukoz commented Feb 5, 2024

did the trick :)

Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any objections @Baccata ?

@Baccata
Copy link
Contributor

Baccata commented Feb 6, 2024

LGTM, any objections @Baccata ?

I think it's fine. Just a minor comment on the parameter name.

@msosnicki
Copy link
Contributor Author

Hmm, failed again on

[error] [aws-sandbox] /home/runner/work/smithy4s/smithy4s/modules/aws-sandbox/target/jvm-2.13/src_managed/main/com/amazonaws/ec2/package.scala:5:13: not found: value EC2Gen
[error] [aws-sandbox]   val EC2 = EC2Gen
[error] [aws-sandbox]             ^
[error] [aws-sandbox] /home/runner/work/smithy4s/smithy4s/modules/aws-sandbox/target/jvm-2.13/src_managed/main/com/amazonaws/ec2/package.scala:4:50: not found: type EC2Gen
[error] [aws-sandbox]   type EC2[F[_]] = smithy4s.kinds.FunctorAlgebra[EC2Gen, F]
[error] [aws-sandbox]                                                  ^
[error] [aws-sandbox] two errors found
[error] [aws-sandbox] (aws-sandbox / Compile / compileIncremental) Compilation failed
[error] Total time: 43 s, completed Feb 6, 2024, 12:55:27 PM

@Baccata
Copy link
Contributor

Baccata commented Feb 6, 2024

that's a bit concerning 😸

@kubukoz kubukoz merged commit e13a718 into disneystreaming:series/0.18 Feb 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants