Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen] add scala 3 keywords to collision avoidance #1392

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

jpassaro
Copy link
Contributor

@jpassaro jpassaro commented Feb 5, 2024

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • (N/A) Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • (N/A) Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@jpassaro
Copy link
Contributor Author

jpassaro commented Feb 6, 2024

thanks kindly to @kubukoz and @Baccata for thoughtful feedback and @daddykotex for the changelog. I think I've got it all covered now.

Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@kubukoz kubukoz merged commit cddd682 into disneystreaming:series/0.18 Feb 6, 2024
11 checks passed
@kubukoz
Copy link
Member

kubukoz commented Feb 6, 2024

Thanks @jpassaro :)

@jpassaro
Copy link
Contributor Author

jpassaro commented Feb 6, 2024

thanks for the merge and swift release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants