Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix infinite recursion when calling Bijection.identity #1401

Merged
merged 1 commit into from
Feb 12, 2024
Merged

fix infinite recursion when calling Bijection.identity #1401

merged 1 commit into from
Feb 12, 2024

Conversation

benoitlouy
Copy link
Contributor

No description provided.

daddykotex
daddykotex approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'm surprised nobody hit that before

@daddykotex daddykotex merged commit cbd5afd into disneystreaming:series/0.18 Feb 12, 2024
11 checks passed
@Baccata
Copy link
Contributor

Baccata commented Feb 13, 2024 •
edited
Loading

An entry in the change log and a unit test (for regression) would have been appreciated, but thank you very much for the fix 👍

edit : @daddykotex, mind taking care of that when you have some time to spare ?

@daddykotex
Copy link
Contributor

I added it to my todos, absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daddykotex daddykotex daddykotex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benoitlouy @Baccata @daddykotex