Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mechanism to plug endpoint-specific middlewares to AWS clients #1452

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

Baccata
Copy link
Contributor

@Baccata Baccata commented Mar 18, 2024

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added documentation
  • Updated changelog

.prepare(service)(endpoint)
.andThen(other.prepare(service)(endpoint))
}
if (this == Middleware.NoopMiddleware) { other }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little optimisation to remove one indirection at runtime

@Baccata Baccata marked this pull request as ready for review March 19, 2024 10:53
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Baccata Baccata merged commit de1a36a into series/0.18 Mar 19, 2024
11 checks passed
@Baccata Baccata deleted the aws-client-middlewares branch March 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants