Add constraints on collection members (address #1488) #1498

miguel-vila · 2024-04-22T10:02:13Z

Address #1488

PR Checklist (not all items are relevant to all PRs)

Added unit-tests (for runtime code)
Added bootstrapped code + smoke tests (when the rendering logic is modified)
Added build-plugins integration tests (when reflection loading is required at codegen-time)
Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
Updated dynamic module to match generated-code behaviour
Added documentation
Updated changelog

Baccata · 2024-04-22T13:59:22Z

Good job ! @kubukoz, wanna review as well ?

modules/bootstrapped/test/src/smithy4s/ConstraintsSmokeSpec.scala

miguel-vila added 5 commits April 22, 2024 11:01

Add constraints on collection members

048924b

add smoke tests

ba98c37

Merge branch 'series/0.18' into constraints-on-collection-members

9f3797d

regenerate

5bdfe4b

add changelog entry

76dafd9

miguel-vila marked this pull request as ready for review April 22, 2024 13:21

Baccata approved these changes Apr 22, 2024

View reviewed changes

kubukoz self-requested a review April 22, 2024 14:43

kubukoz approved these changes Apr 22, 2024

View reviewed changes

modules/bootstrapped/test/src/smithy4s/ConstraintsSmokeSpec.scala Outdated Show resolved Hide resolved

Update modules/bootstrapped/test/src/smithy4s/ConstraintsSmokeSpec.scala

599bccd

kubukoz merged commit bb0b26f into disneystreaming:series/0.18 Apr 22, 2024
11 checks passed

kubukoz mentioned this pull request Apr 22, 2024

Constraints on collections members are not enforced #1488

Closed

miguel-vila deleted the constraints-on-collection-members branch April 22, 2024 15:43