Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small note in refinement docs for scala 3 users #1524

Merged
merged 1 commit into from
May 16, 2024

Conversation

lenguyenthanh
Copy link
Contributor

Because otherwise We'll have this error:

[error]    |No given instance of type smithy4s.RefinementProvider[fide.spec.PageFormat, String, fide.types.Natural] was found for parameter refinementProvider of method apply in class PartiallyAppliedRefinement.
[error]    |I found:
[error]    |
[error]    |    smithy4s.RefinementProvider.isomorphismConstraint[C, A, A0]
[error]    |
[error]    |But method isomorphismConstraint in trait LowPriorityImplicits does not match type smithy4s.RefinementProvider[fide.spec.PageFormat, String, fide.types.Natural].
[error]    |
[error]    |Note: given instance given_RefinementProvider_PageFormat_String_Natural in
[error]    |  object providers was not considered because it was not imported with `import given`.

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

Because otherwise We'll have this error:
```
[error]    |No given instance of type smithy4s.RefinementProvider[fide.spec.PageFormat, String, fide.types.Natural] was found for parameter refinementProvider of method apply in class PartiallyAppliedRefinement.
[error]    |I found:
[error]    |
[error]    |    smithy4s.RefinementProvider.isomorphismConstraint[C, A, A0]
[error]    |
[error]    |But method isomorphismConstraint in trait LowPriorityImplicits does not match type smithy4s.RefinementProvider[fide.spec.PageFormat, String, fide.types.Natural].
[error]    |
[error]    |Note: given instance given_RefinementProvider_PageFormat_String_Natural in
[error]    |  object providers was not considered because it was not imported with `import given`.
```
Copy link
Contributor

@Baccata Baccata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Baccata Baccata merged commit 971c1fe into disneystreaming:series/0.18 May 16, 2024
11 checks passed
@lenguyenthanh lenguyenthanh deleted the patch-1 branch May 16, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants