Implement a simple SchemaDescription visitor #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baccata
reviewed
Jul 7, 2022
Baccata
reviewed
Jul 7, 2022
Baccata
reviewed
Jul 7, 2022
Baccata
reviewed
Jul 7, 2022
Baccata
reviewed
Jul 7, 2022
Baccata
reviewed
Jul 7, 2022
|
I'll mark this as draft, I'm not able to implement |
|
Ready for review I guess |
Baccata
reviewed
Jul 8, 2022
Baccata
reviewed
Jul 8, 2022
Baccata
reviewed
Jul 8, 2022
Baccata
approved these changes
Jul 8, 2022
|
Remarking as draft, I just merged into my other branch and I'm not satisfied. Everything works fine, but the |
Baccata
reviewed
Jul 10, 2022
| @@ -42,4 +42,27 @@ trait SchemaVisitor[F[_]] extends (Schema ~> F) { | |||
| case SurjectionSchema(schema, to, from) => surject(schema, to, from) | |||
| case LazySchema(make) => lazily(make) | |||
| } | |||
|
|
|||
| def mapK[G[_]](f: F ~> G): SchemaVisitor[G] = { | |||
There was a problem hiding this comment.
To remove. Schema ~> F already has andThen which achieves exactly the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is what was expected, mostly because I figure the solution is much more verbose than the current solution. On the other side, this visitor will be available for other usages if we need it.