Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize serialization for ArraySeq #297

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Optimize serialization for ArraySeq #297

merged 1 commit into from
Jul 8, 2022

Conversation

plokhotnyuk
Copy link
Contributor

No description provided.

@daddykotex
Copy link
Contributor

This seems so mechanical that I'm surprised it's not how foreach would be implemented. Is it because using foreach is just more expensive than a while loop because of some reason (boxing and what not?)?

@plokhotnyuk
Copy link
Contributor Author

This seems so mechanical that I'm surprised it's not how foreach would be implemented. Is it because using foreach is just more expensive than a while loop because of some reason (boxing and what not?)?

We cannot avoid boxing/unboxing here, but save on iterator creation and accessing it.

daddykotex
daddykotex approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again

@Baccata Baccata merged commit 612fb28 into disneystreaming:main Jul 8, 2022
@kubukoz kubukoz mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daddykotex daddykotex daddykotex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plokhotnyuk @daddykotex @Baccata