Add enum value names #304
Merged
Add enum value names #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Jul 12, 2022
| @@ -575,9 +575,10 @@ private[codegen] class Renderer(compilationUnit: CompilationUnit) { self => | |||
| hints: List[Hint] | |||
| ): Lines = lines( | |||
| block( | |||
| line"sealed abstract class $name(_value: String, _ordinal: Int) extends $Enumeration_.Value" | |||
| line"sealed abstract class $name(_value: String, _name: String, _ordinal: Int) extends $Enumeration_.Value" | |||
There was a problem hiding this comment.
Couldn't decide on whether this should be optional or not.
Against optionality:
- smithy 2 enums seem to enforce names
- cleaner API, consistent usage among implementations that read this field
For optionality:
- smithy 1 enums don't enforce names (unless you provide at least one of them)
There was a problem hiding this comment.
Nah I'm cool with planning ahead.
Baccata
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.