Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@errorMessage trait #320

Merged
merged 9 commits into from
Jul 27, 2022
Merged

@errorMessage trait #320

merged 9 commits into from
Jul 27, 2022

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Jul 18, 2022 •
edited
Loading

No description provided.

@kubukoz
Copy link
Member Author

kubukoz commented Jul 18, 2022

todo: docs

@kubukoz kubukoz changed the title error message trait @errorMessage trait Jul 18, 2022
@Baccata
Copy link
Contributor

Baccata commented Jul 19, 2022

LGTM so far.

@kubukoz kubukoz marked this pull request as ready for review July 20, 2022 18:15
@kubukoz
Copy link
Member Author

kubukoz commented Jul 20, 2022

ready to go (I think)

@daddykotex
Copy link
Contributor

LGTM, albeit a little thing with the selector. It seems, to me, that we should only allow @errorMessage on structure that have @error on them. and this can be implemented with the selector

@daddykotex
Copy link
Contributor

pinging poor errorMessage for no reason :P

@daddykotex daddykotex marked this pull request as draft July 20, 2022 21:23
@daddykotex
Copy link
Contributor

Added validation via a validator: structure needs a @error trait and the member that's annotated has to be a string

@daddykotex daddykotex marked this pull request as ready for review July 21, 2022 14:13
daddykotex
daddykotex approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @Baccata when you have a minute to confirm that my requirements on the trait were ok:

  • member needs to be a string
  • container structure has to be annotated with @error

@Baccata Baccata merged commit 6d35ead into disneystreaming:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baccata Baccata Baccata approved these changes

@daddykotex daddykotex daddykotex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubukoz @Baccata @daddykotex