Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decline interpreters #376

Merged
merged 17 commits into from
Aug 23, 2022
Merged

Add support for decline interpreters #376

merged 17 commits into from
Aug 23, 2022

Conversation

yisraelU
Copy link
Contributor

@yisraelU yisraelU commented Aug 17, 2022 •
edited by Baccata
Loading

Adds a module to provide a CLI for all Smithy4s generated services

kubukoz
kubukoz reviewed Aug 17, 2022
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@yisraelU yisraelU requested a review from kubukoz August 17, 2022 19:35
Baccata
Baccata reviewed Aug 18, 2022
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@Baccata Baccata changed the title moved Smithy4s-cli repo under smithy4s Add support for decline interpreters Aug 18, 2022
@Baccata Baccata marked this pull request as ready for review August 18, 2022 09:47
@Baccata Baccata marked this pull request as draft August 18, 2022 09:48
@yisraelU
Copy link
Contributor Author

Currently keeping Monovore Effect as we are providing an actual runnable cli via CommandIOApp .
I am not sure about @Baccata regarding removing the effect lib and just using core.
Perhaps it was to be removed and we would limit ourselves to providing a Command aka Argument parser leaving the user to implement the actual interface

@daddykotex
Copy link
Contributor

localhost_3000_smithy4s_docs_protocols_deriving-cli

@yisraelU yisraelU marked this pull request as ready for review August 19, 2022 18:18
daddykotex
daddykotex reviewed Aug 23, 2022
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
kubukoz
kubukoz reviewed Aug 23, 2022
View reviewed changes
modules/decline/src/core/OptsVisitor.scala Outdated Show resolved Hide resolved
modules/decline/src/core/OptsVisitor.scala Outdated Show resolved Hide resolved
modules/decline/src/core/commons.scala Outdated Show resolved Hide resolved
yisraelU and others added 2 commits August 23, 2022 12:56
@yisraelU
update dependencies
e4eb673 
minor changes to decline usage
@daddykotex
Formatting
964e708
daddykotex
daddykotex approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor formatting commit, will merge on success

great work to you and @kubukoz

@daddykotex daddykotex merged commit 474efdc into main Aug 23, 2022
@kubukoz kubukoz deleted the cli branch August 23, 2022 18:38
@kubukoz
Copy link
Member

kubukoz commented Aug 23, 2022

really happy to see this merged! :shipit:

@yisraelU
Copy link
Contributor Author

@kubukoz me too , really great feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz left review comments

@Baccata Baccata Baccata left review comments

@daddykotex daddykotex daddykotex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yisraelU @daddykotex @kubukoz @Baccata