Dynamic smithy4s enums + allow IntEnum hint in JSON codecs #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Aug 23, 2022
modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/src/main/scala/Main.scala
Outdated
Show resolved
Hide resolved
kubukoz
reviewed
Aug 23, 2022
modules/codegen-plugin/src/sbt-test/codegen-plugin/defaults/src/main/scala/Main.scala
Show resolved
Hide resolved
daddykotex
commented
Aug 23, 2022
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
kubukoz
reviewed
Aug 23, 2022
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
kubukoz
reviewed
Aug 23, 2022
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Outdated
Show resolved
Hide resolved
kubukoz
reviewed
Aug 23, 2022
kubukoz
changed the title
kubukoz
reviewed
Aug 24, 2022
| @@ -389,7 +484,7 @@ private[dynamic] object Compiler { | |||
| ) | |||
| } | |||
| val memberHints = allHints(mShape.traits) | |||
| lField.map(_.addHints(memberHints: _*)) | |||
| lField.map(_.addHints(memberHints.all.toSeq: _*)) | |||
There was a problem hiding this comment.
this is one problematic case - I wanted to add an addHints overload to SchemaFieldOps, but that breaks binary compatibility on 2.12 (the existing extension is renamed due to weird 2.12 compiler behavior). We can consider it for 0.16.0, in the meantime here's the workaround.
daddykotex
commented
Aug 24, 2022
modules/dynamic/src/smithy4s/dynamic/internals/DynamicModelCompiler.scala
Show resolved
Hide resolved
|
Added a test in ae28247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.