Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04-deriving-cli.md #410

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Update 04-deriving-cli.md #410

merged 2 commits into from
Aug 24, 2022

Conversation

yisraelU
Copy link
Contributor

fixed relative link to overview

fixed relative link to overview
Co-authored-by: Jakub Kozłowski <kubukoz@gmail.com>
@daddykotex
Copy link
Contributor

oh yeah, I had just caught that
I found it via another PR

I tweaked the checks so they don't go under the radar. What's weird for me is the mdoc correctly told us that the links were dead but as a warning and does not fail the task, so it went unnoticed.

There is an option to disable link-hygiene, but not make it fail

@kubukoz
Copy link
Member

kubukoz commented Aug 24, 2022

There is an option to disable link-hygiene, but not make it fail

That seems like oversight. Did you check for existing/closed issues in mdoc?

@kubukoz kubukoz merged commit 7a8ceb1 into main Aug 24, 2022
@kubukoz kubukoz deleted the yisraelU-patch-1 branch August 24, 2022 15:47
@daddykotex
Copy link
Contributor

That seems like oversight. Did you check for existing/closed issues in mdoc?

I had a quick look but could not find anything related. I will see if I can open an issue and a subsequent PR
Screen Shot 2022-08-24 at 11 49 50

@daddykotex
Copy link
Contributor

ref: scalameta/mdoc#679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants