update how mixins and structs with mismatches are handled #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daddykotex
approved these changes
Sep 1, 2022
Baccata
approved these changes
Sep 1, 2022
Baccata
reviewed
Sep 1, 2022
| ) | ||
| ) | ||
| val mixinMembers = mixin.getAllMembers().asScala | ||
| mixinMembers.foldLeft(true) { case (state, (memberName, member)) => |
There was a problem hiding this comment.
Dammit, yeah haha I'll update
daddykotex
added a commit
that referenced
this pull request
May 5, 2024
Similar to what was done in #425, I've filtered out the mixins that have different type than the final shape they're applied to. As such, in the example above, `HasName` has a optional name member where as `Person` inherits the mixin but makes the member required. The filtering catches that and as a result the mixin is removed from the list of mixins to add on `Person`. This behaviour aligns with the behaviour that happens when no `@adt` trait is added and `Person` is code generated on it's own. In both cases, now, the trait `HasName` is not extended because the types of `name` don't align.
7 tasks
Baccata
pushed a commit
that referenced
this pull request
May 8, 2024
* Filter mixins that have different types Similar to what was done in #425, I've filtered out the mixins that have different type than the final shape they're applied to. As such, in the example above, `HasName` has a optional name member where as `Person` inherits the mixin but makes the member required. The filtering catches that and as a result the mixin is removed from the list of mixins to add on `Person`. This behaviour aligns with the behaviour that happens when no `@adt` trait is added and `Person` is code generated on it's own. In both cases, now, the trait `HasName` is not extended because the types of `name` don't align.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update that will make it so case classes no longer extend mixin-related traits when they contain fields that do not match in type (optional vs. required, etc). See examples in this PR for more cases.
Resolves #422.