Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collision #451

Merged
merged 7 commits into from
Sep 14, 2022
Merged

Fix collision #451

merged 7 commits into from
Sep 14, 2022

Conversation

yisraelU
Copy link
Contributor

This PR resolves a bug that causes collisions to go undetected when the identifier contains a Path
This affects all schema ref's as the name is A.schema or A.underlyingSchema

@Baccata
Copy link
Contributor

Baccata commented Sep 13, 2022

@yisraelU, you can't use distinctBy as it's not part of the Scala 2.12 stdlib

@Baccata Baccata merged commit b257e4c into main Sep 14, 2022
@Baccata Baccata deleted the fix-collision branch September 14, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants