Unify schematic struct methods #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having arity-specific primitive methods in the Schematic interface is just counter-productive, and all our schematic implementations delegate to the arity-generic one.
kubukoz
approved these changes
Jan 25, 2022
Baccata
added a commit
that referenced
this pull request
May 10, 2022
Having arity-specific primitive methods in the Schematic interface is just counter-productive, and all our schematic implementations delegate to the arity-generic one. This PR blesses that approach, and removes the need for GenericAritySchematic, since the new Schematic interface now contains a single method to handle structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having arity-specific primitive methods in the Schematic interface is just counter-productive, and all our schematic implementations delegate to the arity-generic one anyway.
This PR blesses that approach, and removes the need for
GenericAritySchematic, since the newSchematicinterface now contains a single method to handle structures.More objectively : the arity-specific methods and the arity-generic one were non-orthogonal conceptually,
which is a bit of a smell.