smithy4s.Hints.Key => smithy4s.ShapeTag #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extracts the hint key into its own called ShapeTag : it may not be used just for its thing. * Creates a `SchemaIndex` that is a map of `ShapeTag` to `Schema`. * Updates the ProtocolInterface to be constructed with the SchemaIndex instead, which the HintMask is derived This is gonna be tremendously useful for the Dynamic work
kubukoz
approved these changes
Jan 28, 2022
| @@ -309,7 +309,7 @@ private[codegen] class Renderer(compilationUnit: CompilationUnit) { self => | |||
| block( | |||
| s"implicit val protocol: smithy4s.Protocol[$name] = new smithy4s.Protocol[$name]" | |||
| ) { | |||
| s"def hintMask: smithy4s.HintMask = smithy4s.HintMask($protocolTraits)" | |||
| s"def schemas: smithy4s.SchemaIndex = smithy4s.SchemaIndex($protocolTraits)" | |||
There was a problem hiding this comment.
this looks very promising in general
| def withHints[A](fa: F[A], hints: Hints): F[A] | ||
| } | ||
|
|
||
| private[smithy4s] class Impl( |
There was a problem hiding this comment.
Suggested change
| private[smithy4s] class Impl( | |
| private[smithy4s] final class Impl( |
| case class Binding[A](key: Key[A], value: A) { | ||
| def tuple: (Key[A], Binding[A]) = key -> this | ||
| case class Binding[A](key: ShapeTag[A], value: A) { | ||
| def tuple: (ShapeTag[A], Binding[A]) = key -> this |
There was a problem hiding this comment.
if you wanna be fancy... does this work?
Suggested change
| def tuple: (ShapeTag[A], Binding[A]) = key -> this | |
| def tuple: (ShapeTag[A], this.type) = key -> this |
lewisjkl
approved these changes
Jan 28, 2022
Baccata
added a commit
that referenced
this pull request
May 10, 2022
* Extracts the hint key into its own called ShapeTag : it may not be used just for its hints anymore. * Creates a `SchemaIndex` that is a map of `ShapeTag` to `Schema`. * Updates the ProtocolInterface to be constructed with the SchemaIndex instead, which the HintMask is derived This is gonna be tremendously useful for the Dynamic work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be used just for its hints anymore.
SchemaIndexthat is a map ofShapeTagtoSchema.instead, which the HintMask is derived
This is gonna be tremendously useful for the Dynamic work