Remove unused function and add runner tests/mocks #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanFaust
reviewed
Aug 6, 2020
| @@ -56,39 +55,41 @@ func (m *MockSSMClient) TerminateSession(input *ssm.TerminateSessionInput) (outp | |||
| } | |||
|
|
|||
| func (m *MockSSMClient) GetCommandInvocation(input *ssm.GetCommandInvocationInput) (output *ssm.GetCommandInvocationOutput, err error) { | |||
There was a problem hiding this comment.
We should take a look at leveraging GoMock/mockgen moving forward
JordanFaust
approved these changes
Aug 6, 2020
jschell12
approved these changes
Aug 13, 2020
sendqueery
force-pushed
the
inv-result-refactor
branch
from
5f9767c
to
3d7a3b6
Compare
sendqueery
added a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some unused code and improving test coverage for fetching invocation results.