Testing workflow and paginated test fixes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschell12
approved these changes
Aug 31, 2020
|
This looks great! |
ncatelli
commented
Aug 31, 2020
| // instanceMatchesFilter converts the instance information to its string representation | ||
| // and then checks that that information containes atleast one value in the | ||
| // filter. This is a hack but should be sufficient for tests. | ||
| func instanceMatchesFilter(instance ssm.InstanceInformation, filter ssm.InstanceInformationStringFilter) bool { |
There was a problem hiding this comment.
This is a hack, but i figured it would be sufficient for the sake of the limited needs of the mock and would be better than working with reflection to pull out field names or hard coding them. Please let me know if you feel otherwise though.
JordanFaust
reviewed
Aug 31, 2020
|
Manually tested everything after these changes and everything looked good as well. |
jschell12
approved these changes
Aug 31, 2020
JordanFaust
approved these changes
Aug 31, 2020
sendqueery
pushed a commit
that referenced
this pull request
Sep 3, 2020
* Add devcontainer * Add Code Quality workflow * Fix unformatted code. * Remove the redundant G * WIP: Stub DescribeInstanceInformationPages * implement paginator mock * Add pagination and filtering to mock * Fix ec2 mocks traceback. * Fix EC2 tags tests * Remove extra newline * Add missing newline to code_quality.yml * format -> format.check * else -> happy path on mock conditionals * Add path to gofmt stage. * ec2 mocks test to ElementsMatch to ignore ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
This PR includes test fixes, additional developer tooling and a new workflow.
Test Fixes
This PR implements a new method on the ssm and ec2 mocks respectively to cover paginator calls. After the included changes tests are passing again.
These changes are:
DescribeInstanceInformationPagesmethod in the ssm API mocksDescribeInstancesPagesmethod in the ec2 API mocksNew Workflow
This PR also introduces a new
code_qualityworkflow that handles runningmake formatandmake teston PR creation.Other Changes
In addition to the above fixes, this PR includes a few additional small changes
make formatto format branch