fix: Allow non-pr runs to pass ci #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprospero
changed the title
trisyoungs
reviewed
Apr 10, 2024
.github/workflows/qc/action.yml
Outdated
Comment on lines
18
to
25
| run: | | ||
| set -ex | ||
| echo ${{ github.event.pull_request.title }} | awk "/(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep . | ||
| TITLE="${{ github.event.pull_request.title }}" | ||
| if [ -z "$TITLE" ] | ||
| then | ||
| TITLE=Continuous | ||
| fi | ||
| echo $TITLE | awk "/(Continuous)|(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep . |
There was a problem hiding this comment.
Just an alternative suggestion, but you could avoid the if/else title set and check by adding if: github.event_name == 'pull_request' on to the step perhaps?
There was a problem hiding this comment.
@trisyoungs That had been my original idea, but I was paranoid that I wouldn't be able to test it. However, looking at it again, you're right that the simplicity makes it worth the change.
There was a problem hiding this comment.
@rprospero Sometimes its hard to have faith in the mess that is GitHub if checks, but live dangerously I say!
trisyoungs
approved these changes
Apr 10, 2024
.github/workflows/qc/action.yml
Outdated
| shell: bash | ||
| run: | | ||
| set -ex | ||
| echo ${{ github.event.pull_request.title }} | awk "/(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep . | ||
| echo ${{ github.event.pull_request.title }} | awk "/(Continuous)|(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep . |
There was a problem hiding this comment.
Guess this change is redundant now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable GitHub runners that do not have a PR title (e.g. the continuous runn) to automatically pass the conventional commit checks.