Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow non-pr runs to pass ci #1839

Merged
merged 6 commits into from Apr 10, 2024
Merged

fix: Allow non-pr runs to pass ci #1839

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2c9cdc
fix: Allow non-pr runs to pass ci
rprospero Apr 10, 2024
22b8dca
Fix bash script
rprospero Apr 10, 2024
ff64a83
Remove extra fi
rprospero Apr 10, 2024
d1cf512
Actually include the title we went theough the trouble of generating
rprospero Apr 10, 2024
4bd2867
Use GitHub logic
rprospero Apr 10, 2024
3652c6d
Remove vestigal check for Continuous branch
rprospero Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/qc/action.yml
View file
Open in desktop
Expand Up @@ -17,7 +17,12 @@ runs:
shell: bash
run: |
set -ex
echo ${{ github.event.pull_request.title }} | awk "/(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep .
TITLE="${{ github.event.pull_request.title }}"
if [ -z "$TITLE" ]
then
TITLE=Continuous
fi
echo $TITLE | awk "/(Continuous)|(^feat:)|(^fix:)|(^doc:)|(^perf:)|(^refactor:)|(^style:)|(^test:)|(^chore:)|(^revert:)|(^build:)/" | grep .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an alternative suggestion, but you could avoid the if/else title set and check by adding if: github.event_name == 'pull_request' on to the step perhaps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trisyoungs That had been my original idea, but I was paranoid that I wouldn't be able to test it. However, looking at it again, you're right that the simplicity makes it worth the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rprospero Sometimes its hard to have faith in the mess that is GitHub if checks, but live dangerously I say!


- name: C++ Formatting
shell: bash
Expand Down