1415 Code Tidy 2023 - Part 1 #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
1415-code-tidy-2023-pt1
branch
from
9931d18
to
844e9ad
Compare
jws-1
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
For such a massive PR, the review didn't end up taking very long! Everything seems OK so far. I see what you mean now regarding the class_something files. I wonder if we should consider having a separate directory for such classes, and then dropping the underscore notation? Just something to think about.
|
@jws-1 It's on the to-do list as a "trial" PR to follow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the first arduous step towards code tidying 2023, renaming the vast majority of files to conform to lowerCamelCase.
Future PRs will address remaining reorganisation and restructuring in (much!) smaller PRs.
Works towards #1415.