as.File has File Descriptor leak

[seraphr]

When http request is failed, java.io.RandomAccessFile is not closed.

https://github.com/dispatch/reboot/blob/master/core/src/main/scala/as/core.scala#L35

[Sciss]

Is there any workaround?

[seraphr]

@Sciss
I wrote alternative implementation.

object AsFile {
  def apply(file: java.io.File) = {
    val tFile = new java.io.RandomAccessFile(file, "rw")
    (new client.resumable.ResumableAsyncHandler with OkHandler[Nothing] {
      override def onThrowable(t: Throwable): Unit = {
        super.onThrowable(t)
        try tFile.close() catch { case e: Throwable => }
      }
    }).setResumableListener(
      new client.extra.ResumableRandomAccessFileListener(
        tFile
      )
    )
  }
}

[Sciss]

Thanks - I'm also having a custom AsFile-like thing now (https://gist.github.com/Sciss/bea9022d90a4f0ad7556e8fa283ff459) as I want to monitor download progress, so adding that onThrowable is straight forward.