Scala 2.12.0

[QuadStingray]

Please build Dispatch with Scala 2.12.0

[SethTisue]

no commits for well over a year, so I think a new maintainer will need to be found. anyone out there want to take it on? even if the project doesn't really move forward in any substantive way, it would be good at least have someone who's willing to do basic keep-the-lights-on stuff like a 2.12 release

[mdedetrich]

I would take it on, but maybe we should wait for the maintainer to respond in a couple of days. Is he contactable by email?

In the mean time will do a pull request

[mdedetrich]

Can't update until unfiltered/unfiltered#319 is solved

[SethTisue]

@eed3si9n are you able to help with this (adding new maintainers) at the same time as unfiltered/unfiltered#320?

[eed3si9n]

I'm just an outside cheerleader, and don't have membership to either orgs.

Edit: Now I do for Unfiltered.

[SethTisue]

@softprops do you have the same magical magical-powers-granting powers here as you did over in unfiltered-land?

[mdedetrich]

Pull request for unfiltered for 2.12 support has been made here unfiltered/unfiltered#330

When its published to a version than Dispatch can follow

[ashawley]

Is the proposal to build dispatch 0.11.2 for Scala 2.12? Because that would be great.

Isn't the important issue having the magical-powers to publish to Sonatype, and not so much about GitHub?

[mdedetrich]

Is the proposal to build dispatch 0.11.2 for Scala 2.12? Because that would be great.

It can't currently be built due to unfiltered dependency not working for Scala 2.12

Isn't the important issue having the magical-powers to publish to Sonatype, and not so much about GitHub?

Yup, @SethTisue messaged the maintainer already

[ashawley]

It can't currently be built due to unfiltered dependency not working for Scala 2.12

dispatch 0.11.2 depends on unfiltered 0.8.4. Looks like the unfiltered issue you raised is fixing 0.9.0. Shouldn't it be for 0.8.4?

[mdedetrich]

I suppose its assumed that Dispatch will update its dependency, in the worst case I don't think that backporting would be that painful

[ashawley]

Seems risky. Looks like unfiltered/unfiltered#321 removes dispatch as a (circular) dependency, replacing it with www.github.com/square/okhttp. Will that change introduce source compatibility problems? I haven't pulled on the thread long enough to know what's at the end.

[softprops]

@softprops do you have the same magical magical-powers-granting powers here as you did over in unfiltered-land?

I just have the default member level permissions here so I can't invite new members :/ I think only @n8han can invite new members. There's only two members in listed under https://github.com/orgs/dispatch/people.

[ashawley]

Looking further, it appears that unfiltered isn't a true circular dependency. It's only a dependency for testing. Scala 2.12 will compile 0.11.2 without a problem once you drop unfiltered from build.sbt. Perhaps, there just needs to be a 0.11.2-RC1 for Scala 2.12 published?

[ashawley]

I've suggested that a build of unfiltered-netty-server 0.8.4 be published for Scala 2.12 in unfiltered/unfiltered#338

But again, a build of Dispatch for 2.12 can be done without Unfiltered.

Does anyone have the permissions to publish a 0.11.2 build for Scala 2.12 to Sonatype?

[ashawley]

A 2.12 build of Dispatch 0.11.2 would require moving json4s from 3.2.10 to 3.4.2 and scala-xml from 1.0.1 to 1.0.5

See f511a25 for producing a 0.11.2-RC1 build from the 0.11.2 tag.

Publishing would be:

$ sbt ++2.12.0 publish

The changes for json4s are:

json4s/json4s@v3.2.10...v3.4.2

The changes for scala-xml are:

scala/scala-xml@v1.0.1...v1.0.5

[mdedetrich]

@ashawley This is just for building though, tests are still broken right (due to unfiltered not being published)

[leonardehrenfried]

I also want to chime in and say that I'm willing to help out with the maintainership. However getting approval and/or credentials from @n8han seems to be the top priority. Has anyone succeeded in getting in touch with him?

I don't wanna be all stalkerish but his twitter account (https://twitter.com/n8han) has been active in the last 24h so he probably hasn't gone off the grid.

[mdedetrich]

@leonardehrenfried I have received ownership of the organisation, I think the only thing missing is publish rights to sonatype

[leonardehrenfried]

Good to hear.

Do you plan to cut the Scala 2.12 release from this repo (reboot) or the main one (dispatch/dispatch)?

[mdedetrich]

From reboot (reboot is meant to be the latest version/implementation of dispatch)

[fbascheper]

A build of unfiltered 0.8.4 for Scala 2.12 isn't going to happen, but instead a build of unfiltered v0.9.0-beta2 has been published to maven central. See here for the pom file. Also note that the group id has changed in the process.

Any chance this helps in getting a first 2.12 build of dispatch?

[mdedetrich]

@fbascheper Thanks, I will have a look into it

[fbascheper]

Can you take a look at this request. It fixes the build on my machine.
I still have a couple of warnings though, and I'd like to upgrade scalacheck to a recent version, which also introduces a few extra warnings (sigh).

[mdedetrich]

Thanks, I have merged the pull request. I am just waiting for Sonatype permissions to deploy know. I have also bumped the version to 0.12.0.

[farmdawgnation]

@mdedetrich Do you have an ETA on getting those Sonatype permissions? I've got another project I'd like to add 2.12 support for, but I'm waiting on Dispatch to be updated.

Also, would y'all like help maintaining dispatch? I sent an email to @n8han awhile back offering to help since I've got so many projects that use it and it's still my favorite HTTP abstraction for Scala, but never got a reply.

[mdedetrich]

@farmdawgnation @n8han Is currently on holidays but when he returns he needs to make an issue on SonaType to add me as part of the contributors, so I wouldn't expect anything really soon

Regarding maintenance, I don't have a personal issue with it but maybe its better to see what @n8han thinks

[raboof]

Can we post a SNAPSHOT release somewhere while we wait for the proper sonatype credentials to come through?

[raboof]

I uploaded "net.bzzt" %% "dispatch-core" % "0.12.0-SNAPSHOT" to Sonatype Snapshots - this is 88fde3a with the organization and version settings modified.

[mdedetrich]

I am going to reopen this issue until I get to deploy

Unfortunately, I am not getting a response from @n8han in regards to giving me deploy rights on sonatype (he is currently on vacation so it may take a while)

[mdedetrich]

Since there are also some pull requests with issues that have been umerged and we are doing a major bump, I am going to merge this pull requests and retag for v0.12.0

[leonardehrenfried]

I know this is ungrateful but if the original maintainer isn't responding it may be worth publishing this under a new group id.

This issue has been open for a while.

[ashawley]

That was how unfiltered/unfiltered#351 had to be resolved.

[leonardehrenfried]

Maybe we should give ourselves one more week and if @mdedetrich hasn't received deploy permissions deploy under a different group id.

What do people think about that?

[mdedetrich]

@leonardehrenfried Sure thing, I am happy with that. We should probably try and find a new group id that works with the project

[mdedetrich]

https://issues.sonatype.org/browse/OSSRH-27773

Should get the permissions within a couple of days at which point I will deploy

[leonardehrenfried]

Oh, that's fantastic news! I was hoping we would be able to keep the group id and resolve this in cooperation with Nathan.

…

On 23 January 2017 at 10:23, Matthew de Detrich ***@***.***> wrote: https://issues.sonatype.org/browse/OSSRH-27773 Should get the permissions within a couple of days at which point I will deploy — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#134 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPMn4UNcZCPRaaw3gHOBV8z9YCFTI5ks5rVHGQgaJpZM4KrAIU> .

[mdedetrich]

Okay so the permission came through, I will wait two days to see if we can get #128 in for 0.12.0 (@alexdupre just has to rebase the branch against 0.12.0)

[ashawley]

Should 0.12 target 1.9, and AHC 2.0 could be 0.13? I'm amending my previous suggestion in #128. I noticed Gigahorse did something similar with AHC versions and its own releases.

[mdedetrich]

I think if possible (and easy), getting AHC 2.0 into 0.13 would be nice, but only if it doesn't require a lot of effort/break a lot of stuff, @ashawley correct me if I am wrong

[alexdupre]

I did the upgrade to AHC 2.0 in Gigahorse and added support for WebSocket, given that there was no intention to maintain and further support dispatch. At the moment I'm using my local dispatch 0.11.4 release only with scalaxb that hasn't been migrated to Gigahorse yet, but I expect that the rebase of my work on 0.12 branch will be straightforward.

[mdedetrich]

Okay in that case, I think 0.13 is a better target (didn't realise the change was that big). Will release dispatch with the current 0.12.0 branch (@ashawley we can probably fix up the branches afterwards)

[alexdupre]

Dispatch 0.11.3 already targets AHC 1.9, why would you like to have the first 0.12 release to target the same old version?

[mdedetrich]

It was a mistake on my part, got mixed up between the versions

[mdedetrich]

Okay, 0.12.0 has been released. It should be available on Maven in around an hour

[jvican]

It's great to see people maintaining dormant libraries the community depends on. I find this is the natural way of growing projects and communities around them. Thanks for the inspiration.