Add support for Linode StackScripts via the stackscript/stackscriptid attributes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tadman, this is great! We should probably sweep the private stackscripts before/separately from searching through the public list. I realize the time involved is probably minimal to the client but it is an efficiency that jumps out. We already run into rate limiting in multi-machine workloads, anything we can do to lighten the request load will help. |
| @@ -29,6 +29,23 @@ def call(env) | |||
| root_pass = Digest::SHA2.new.update(@machine.provider_config.api_key).to_s | |||
| end | |||
|
|
|||
| if @machine.provider_config.stackscript | |||
| stackscripts = @client.stackscript.list + @client.avail.stackscripts | |||
| stackscript = stackscripts.find { |s| s.label.downcase == @machine.provider_config.stackscript.to_s.downcase } | |||
There was a problem hiding this comment.
I'd like to see us find from the private list, then find from the public list if there was no private match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are shown in the documentation as examples but aren't functional. This patch enables that functionality.
Stackscripts are available in both public and private contexts. Names are done with a direct match to avoid false matches in the order of private and then public.
An additional
stackscript_udf_responsesargument is added to conform with the Linode API specification forcreatefromstackscriptas this is a required parameter.