Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building for i386 #217

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Fix building for i386 #217

merged 1 commit into from
Jun 6, 2022

Conversation

shoffmeister
Copy link
Contributor

Fix the build infrastructure to build i386.

At the same time, this sneaks in two slightly unrelated changes:

  • make the buildTest and mockTest runs depend on (the success of) the makeTest job; this results in early failure in case something goes wrong
  • add "set -e" everywhere to fail scripts immediately; this uncovered dnf-builddep being used, which does not exist

Generally it would seem as if the i386 builds might have been broken one way or the other; theoretically the i386 rpm now contains i386 artefacts, but I am not setup to properly test this.

Generally speaking, it might be worthwhile removing build support for simplicity, see #210

@elguero elguero merged commit 8ec5e28 into displaylink-rpm:master Jun 6, 2022
@elguero
Copy link
Collaborator

elguero commented Jun 6, 2022

Thanks! Looks good.

@shoffmeister shoffmeister deleted the fix-fedora36-build branch June 7, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants