Skip to content
This repository has been archived by the owner on Jun 20, 2018. It is now read-only.

throw exception when key longer than 64 characters #103

Closed
wants to merge 1 commit into from

Conversation

switch87
Copy link

I added a check on the length of gargoyle keys, this will prevent problems on SQL-databases with 'Strict SQL Mode' disabled.

@switch87
Copy link
Author

@mattrobenolt

@adamchainz
Copy link
Contributor

Hi @switch87 , we considered merging this into the YPlan gargoyle fork, however because MySQL has many problems without strict mode active, and this only fixes one such problem, we don't think it's worth merging. Please check out my package Django-MySQL, which has a number of Django + MySQL improvements, including a check that recommends strict mode, plus a guide on how to activate it: https://django-mysql.readthedocs.org/en/latest/checks.html#django-mysql-w001-strict-mode .

Thanks!

@switch87
Copy link
Author

@nielsvanoch Django-MySQL is misschien wel interessant voor jullie, dit gaat nog over een probleem war ik bij jullie op gestoten was.

@switch87 switch87 closed this Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants