Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All commands are retryable based on the backend #35

Closed
wants to merge 1 commit into from
Closed

Conversation

dcramer
Copy link
Collaborator

@dcramer dcramer commented Feb 18, 2015

Discuss.

@dcramer
Copy link
Collaborator Author

dcramer commented Feb 18, 2015

If no one comes up with a good reason why the default is False I will push this out. If a connection dictates X exception can retry, it should be retryable outside of things like RoundRobinRouter. If that's not true then it shouldn't be classified as generic retries, and the roundrobinrouter should have some other router-specific code that designates "node down retryable failures".

Specifically using this as a replacement for something like the Riak client isn't useful if retries are handled generically.

@Fluxx
Copy link
Contributor

Fluxx commented Feb 18, 2015

Cool with me. You should remove anywhere where retryable = True and add retryable = False to the routers that need it though.

@dcramer dcramer closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants