Prevent Phabricator.token from shadowing the conduit token API #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduit token endpoints (`token.*`) cannot be called because `token` is alreay in the `Phabricator.__dict__` and shadows the interface methods. This can be prevented by renaming `token` into `conduit_token`. A test case is added to prevent shadowing to occur again.
jasonbcox
approved these changes
Jun 10, 2020
|
@tail @colekowalski @tterb I there anything else that needs to be done to get this PR merged ? |
|
This is an easy to review bug fix. |
|
Looks good to me. |
|
@thekashifmalik Thanks for the merge ! |
|
@Fabcien Don't know if you checked but this change is included in |
|
@thekashifmalik Great, thank you ! |
Fabcien
added a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 8, 2021
Summary: The bugfix patch (disqus/python-phabricator#62) has been released with version 0.8.0. There is no need for keeping our local patched version anymore. Test Plan: pytest Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conduit token endpoints (
token.*) cannot be called becausetokenisalreay in the
Phabricator.__dict__and shadows the interface methods.This can be prevented by renaming
tokenintoconduit_token.A test case is added to prevent shadowing to occur again.